Repository navigation
feat(stylelint-config)!: require stylelint 18 and remove SCSS config - #207
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Stylelint 18.0.0 is the latest release. It needs
@stylistic/stylelint-plugin6, which refuses conflicting settings and reads SCSS files only under the@stylistic/scss/rule names. The SCSS config goes away instead of being ported to those names.What
stylelint18.0.0, and the peer range is now>=18.0.0.@stylistic/stylelint-plugin6.0.1. The other plugins move to their latest releases, whose peer ranges include stylelint 18:stylelint-declaration-strict-value1.13.0,stylelint-gamut2.0.2,stylelint-high-performance-animation2.1.0,stylelint-order8.1.3,stylelint-plugin-a11y1.1.0.declaration-block-single-line-max-declarationsis gone from stylelint, so the config uses@stylistic/declaration-block-single-line-max-declarationswith the same option.@stylistic/block-closing-brace-space-afterand@stylistic/block-opening-brace-newline-beforeare removed. Stylistic 6 refuses them next toblock-closing-brace-newline-after: alwaysandblock-opening-brace-space-before: always, which already define that whitespace.at-charset-rule-no-invalidis on. Stylistic 6 no longer checks@charsetand warns where this rule is off. The rule asks for double quotes, the only spelling browsers accept, while@stylistic/string-quotes: singleused to ask for single quotes there.@trigen/stylelint-config/scssis removed together withpostcss-scss,stylelint-scss, its README entry and thescsskeyword.Notes
mainwith valid and invalid CSS fixtures, through the Node.js API and the CLI. The valid fixtures stay clean. The invalid ones get the same warnings at the same positions, apart from the renamed rule, the two removed rules and one position ofstylelint-plugin-a11yexplained below.--fixin three passes writes the same output, apart from the two a11y fixes below./logicaland/strictload throughextends, and/scssfails to resolve.stylelint-plugin-a11y1.1.0 still readscontext.fix, which stylelint 18 removed, soa11y/selector-pseudo-class-focusanda11y/media-prefers-reduced-motionreport instead of fixing. Its rules also passnode.lastEachasindex, so their positions depend on how many walks other rules made. Both need a fix in that repository.stylelint-plugin-logical-css2.1.0 is its latest release and lists stylelint up to 17 as peer. It works with 18 and does not readcontext.fix, pnpm reports the peer mismatch.stylelint-declaration-strict-value1.13.0 is the first release that allows stylelint 18. It bringsregexp.escapewith about 60 es-shims packages, which is most of the lockfile growth.enginesstays>=22. Stylelint 18 itself asks for Node.js 22.22.2, 24.15.0 or 26.